yueki1993 commented on code in PR #924:
URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r893542193
##########
log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java:
##########
@@ -326,4 +326,9 @@ public void testEnhancedRollingFileAppender() throws
Exception {
}
}
+ @Override
Review Comment:
Should I add test in `Log4j1ConfigurationFactoryTest`, too?
I don't understand the difference of `PropertiesConfigurationTest` and it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
