[
https://issues.apache.org/jira/browse/LOG4J2-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570368#comment-17570368
]
Piotr Karwasz commented on LOG4J2-3537:
---------------------------------------
Hi [~twisterrob],
Thank you for reporting the issue. The problem you are having is not with the
{{highlight}} pattern, but the {{style}} pattern:
* the {{highlight}} pattern separates the keywords with white space: e.g.
"{{INFO=bright white}}",
* the {{style}} pattern separates the keywords with commas: e.g. "{{bright,
white}}".
I agree that this is inconsistent, but it is easily fixable: instead of just
using commas as separators in the {{style}} pattern, we can use commas *or*
white space. This way we take care of backward compatibility and bring some
consistency to the two patterns. Can you open a new JIRA ticket for this and
perhaps submit a PR?
> Ansi escape code for highlight is generated wrong
> -------------------------------------------------
>
> Key: LOG4J2-3537
> URL: https://issues.apache.org/jira/browse/LOG4J2-3537
> Project: Log4j 2
> Issue Type: Bug
> Affects Versions: 2.14.1
> Reporter: Pavel_K
> Priority: Minor
> Fix For: 2.18.0
>
> Attachments: Screenshot from 2022-06-14 16-09-30.png, Screenshot from
> 2022-06-14 16-13-13.png
>
>
> This is a test pattern layout:
> {code:java}
> <PatternLayout pattern="%d{yyyy-MM-dd HH:mm:ss.SSS}
> %highlight{[%level]}{FATAL=red bright, ERROR=red bright, WARN=yellow bright,
> INFO=magenta bright, DEBUG=green, TRACE=blue bright} [%t] %logger{36} -
> %msg%n" disableAnsi="false"/>
> {code}
> As you see for TRACE level is `blue bright`. However, this is a generated
> code:
> [34;1m[TRACE][m . As you see we have
> [SGR|https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_(Select_Graphic_Rendition)_parameters]
> function with two parameters: 34 is color and 1 is bold.
> For example linux terminal will render it this way:
> !Screenshot from 2022-06-14 16-09-30.png!
> We see, that it is not `bright blue` but `bold blue`. At the same time in
> [manual|https://logging.apache.org/log4j/2.x/manual/layouts.html] they speak
> about different colors:
> !Screenshot from 2022-06-14 16-13-13.png!
> And if we want bright blue, generated escape code should be `[94m[TRACE][m`
> - see the link to SGR function I provided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
