rm5248 commented on code in PR #121:
URL: https://github.com/apache/logging-log4cxx/pull/121#discussion_r962900919
##########
src/main/cpp/aprinitializer.cpp:
##########
@@ -56,25 +57,31 @@ APRInitializer::APRInitializer() : p(0), startTime(0),
tlsKey(0)
APRInitializer::~APRInitializer()
{
- {
+ stopWatchDogs();
+ isDestructed = true;
+#ifndef APR_HAS_THREADS
Review Comment:
Shouldn't this be if, not ifndef? I think we always want to delete the
thread data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
