rm5248 commented on PR #135: URL: https://github.com/apache/logging-log4cxx/pull/135#issuecomment-1259370177
I'll need to test this out sometime in the next few days, but that looks good to me. One thing that I would like to double-check is to make sure that re-configuring works correctly at runtime(e.g. calling DOMConfigurator::configure), since it looks like the reparenting and level checking has changed slightly. Are there any other commonly accessed fields that may need to be private? In this case adding it as a private member variable instead of in the private class is reasonable to do for performance purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
