jvz commented on code in PR #1136:
URL: https://github.com/apache/logging-log4j2/pull/1136#discussion_r1015846408
##########
log4j-api/src/main/java/org/apache/logging/log4j/ThreadContext.java:
##########
@@ -414,7 +395,7 @@ public static ContextStack getImmutableStack() {
* @param stack The stack to use.
*/
public static void setStack(final Collection<String> stack) {
- if (stack.isEmpty() || !useStack) {
Review Comment:
This was a premature optimization as the two lines afterwards are no-ops
anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
