theit commented on code in PR #1137:
URL: https://github.com/apache/logging-log4j2/pull/1137#discussion_r1016385846
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java:
##########
@@ -71,8 +72,22 @@ public void format(final LogEvent event, final StringBuilder
toAppendTo) {
if (len > 0 && !Character.isWhitespace(toAppendTo.charAt(len -
1))) {
toAppendTo.append(' ');
}
- proxy.formatExtendedStackTraceTo(toAppendTo,
options.getIgnorePackages(),
+ final String trace =
proxy.getExtendedStackTraceAsString(options.getIgnorePackages(),
Review Comment:
The change in `ExtendedThrowablePatternConverter` is similar to what is
being done in `RootThrowablePatternConverter`. And having a look in the
history, also basically the same as in commit
078f8c877d7454527f100f4331a5c132e70eeb0c...
Regarding your comment, then both classes should be changed and the code
unified; well, at least as far as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
