[ 
https://issues.apache.org/jira/browse/LOG4J2-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641056#comment-17641056
 ] 

Dave Messink commented on LOG4J2-3487:
--------------------------------------

I've discovered that this includeLocation regression exists in both 2.18.0 and 
2.19.0. Specifically for the AsyncRootLogger. I tried to generate a PR – but 
I'm still working through my account issues. I'm attaching a patch file that 
adds a test and patch for the AsyncRootLogger default includeLocation.

> The LoggerConfig includeLocation defaults to true in 2.17.2
> -----------------------------------------------------------
>
>                 Key: LOG4J2-3487
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-3487
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 2.17.2
>            Reporter: Dave Messink
>            Priority: Major
>         Attachments: log4j2-3487-1.patch, log4j2-3487-2.patch, 
> log4j2-3487.patch
>
>
> We've found services running 2.17.2 to be slower than 2.17.1. A heat map 
> indicates a StackWalker in log4j.
> I found that the code that Logger plugin calls into has changed. In 2.17.1 
> the default config for includeLocation is based only on the configured value. 
> In 2.17.2 it's based on the config value if present, but then defaults to 
> !(context instanceof AsyncLoggerContext).
> Since none of our Logger elements declare includeLocation - the default 
> behavior has changed causing all LogEvents to include their location.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to