ams-tschoening commented on PR #170: URL: https://github.com/apache/logging-log4cxx/pull/170#issuecomment-1364053631
> I suggest LOG4CXX_WARN_WITH_STACK and LOG4CXX_ERROR_WITH_STACK would be sufficient. Those macros read like they will always include stacktraces in the output to me, which is not the case, things additionally depend on the configured pattern. Why care at all when some dev wants to have stacktraces, if it's for DEBUG or ERROR? > The reason I didn't make separate macros is that I don't want to change log statements if I now want a stack trace. This argument makes sense to me and the naming of `*_ENABLE_*` doesn't even imply the stacktrace is always embedded into the log message, but only its availability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
