[GitHub] [logging-log4j2] alex-dubrouski opened a new pull request, #1214: This change fixes incorrect behavior of stack elements cache.

Tue, 17 Jan 2023 10:46:21 -0800 


alex-dubrouski opened a new pull request, #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214

   Change of data structure from Stack to Deque (LIFO to FIFO) in this commit 
https://github.com/apache/logging-log4j2/commit/97f3153b73ab071a69c2e61e0130fd0104d45407
 broke cache logic. This bug causes a major performance regression. 
   ![Screen Shot 2023-01-11 at 6 31 58 
PM](https://user-images.githubusercontent.com/36453467/212984460-9c8a63c9-db7d-40c7-b17a-e5ec96a170ed.png)
   ![Screen Shot 2023-01-11 at 6 32 55 
PM](https://user-images.githubusercontent.com/36453467/212984479-1f308cfe-1d20-44ad-bf20-9aa5a75a9bc7.png)
   
   I created a small local project to reproduce the issue. I can attach it if 
needed.
   
   P.S. I signed ICLA and got a confirmation, but haven't got any response to 
my request to create a JIRA account, so can't create a bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to