alex-dubrouski commented on PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1397742320
> Yes, I would expect the class that called `StackLocatorUtil` at the lowest index (or at least near the top), while the class that initiated execution on the thread (JUnit?) at the end. Java9 StackLocator uses "add" method which is for ArrayDeque equals to addLast, so it works as expected. Plus it has a unit test that verifies order of elements already (https://github.com/apache/logging-log4j2/blob/release-2.x/log4j-api-java9/src/test/java/org/apache/logging/log4j/util/java9/StackLocatorTest.java#L60). It also uses WALKER by default as "PrivateSecurityManagerStackTraceUtil.isEnabled()" always returns False. I assume it means we can skip additional tests for Java9 code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
