rm5248 commented on PR #218: URL: https://github.com/apache/logging-log4cxx/pull/218#issuecomment-1598009328
> I think we should move all instances of `IMPLEMENT_LOG4CXX_OBJECT` to loader.cpp. I'm not in favor of that, since if/when we move things to plugins we don't want the plugins referenced in the log4cxx.so file. Keeping the implementation contained to the .cpp files seems cleanest to me. > Is there another way? This is the simplest way with the minimal number of changes. We could do something like adding `attribute((constructor))` to the `IMPLEMENT_LOG4CXX_OBJECT` macro that would do the same thing(call `registerClass` when the .so is loaded), but that is GCC/Clang specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
