ppkarwasz commented on PR #1483: URL: https://github.com/apache/logging-log4j2/pull/1483#issuecomment-1626846096
@aawad6, Sorry for the delay. The changes you did look good to me, but you missed some `toLowerCase/toUpperCase` calls, e.g. in `AnsiEscape` or `HighlightConverter`. Could you replace all calls to `toLowerCase/toUpperCase` that take a constant locale parameter (e.g. `Locale.US` or `Locale.ENGLISH`)? If we remove most of the `String#toLowerCase` callsites it will be easier to check if someone didn't introduce new ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
