rm5248 commented on PR #242:
URL: https://github.com/apache/logging-log4cxx/pull/242#issuecomment-1656760934

   Would that allow both libraries to be installed at the same time and not 
overwrite each other?
   
   These are the options as I see it:
   
   - build both log4cxx and log4cxx-qt using the same sources at the same 
time(assuming Qt support is on).  The two libraries are basically the same at 
that point, but the log4cxx-qt library has extra symbols for use with Qt.
   - Build one or the other.  I don't really like this option, since in my mind 
the core library shouldn't really depend on any 3rd party libraries. and it 
means that you would need to configure twice to build the library, instead of 
configuring once and having two libraries.
   - Add overrides for `operator<<` and `fmt` that take in a QString.  This 
doesn't make the API easier to use, but it makes logging easier.
   - Create a `QLogger` class that extends `Logger`, taking in a `QString` 
parameter.
   - Do nothing
   
   The third option seems like the easiest to do to make logging easier.  The 
fourth would work somewhat but because of the `LoggerManager` that tracks the 
loggers, we would probably need to create a separate `QLoggerManager` as well.  
Unifying those two may be difficult.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to