rgoers commented on code in PR #1639:
URL: https://github.com/apache/logging-log4j2/pull/1639#discussion_r1278624198
##########
log4j-perf/src/main/java/org/apache/logging/log4j/message/ParameterFormatterBenchmark.java:
##########
@@ -51,135 +46,83 @@ public static class ThreadState {
char[] copy = new char[4096];
}
Review Comment:
Why are all these methods deleted?
##########
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##########
@@ -17,156 +17,167 @@
package org.apache.logging.log4j.message;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.MethodSource;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests {@link ParameterFormatter}.
*/
public class ParameterFormatterTest {
Review Comment:
How do I know you didn't change behavior when you have modified the tests?
##########
log4j-perf/src/main/java/org/apache/logging/log4j/message/ParameterFormatterBenchmark.java:
##########
@@ -51,135 +46,83 @@ public static class ThreadState {
char[] copy = new char[4096];
}
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency3ParamsV3(final ThreadState state) {
- state.buffer.setLength(0);
- final String STR = "p1={}, p2={}, p3={}";
- final int length = STR.length();
- STR.getChars(0, length, state.copy, 0);
- final int count =
ParameterFormatter.countArgumentPlaceholders3(state.copy, length,
state.indices);
- ParameterFormatter.formatMessage3(state.buffer, state.copy, length,
ARGS, count, state.indices);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency5ParamsV3(final ThreadState state) {
- state.buffer.setLength(0);
- final String STR = "p1={}, p2={}, p3={}, p4={}, p5={}";
- final int length = STR.length();
- STR.getChars(0, length, state.copy, 0);
- final int count =
ParameterFormatter.countArgumentPlaceholders3(state.copy, length,
state.indices);
- ParameterFormatter.formatMessage3(state.buffer, state.copy, length,
ARGS, count, state.indices);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency7ParamsV3(final ThreadState state) {
- state.buffer.setLength(0);
- final String STR = "p1={}, p2={}, p3={}, p4={}, p5={}, p6={}, p7={}";
- final int length = STR.length();
- STR.getChars(0, length, state.copy, 0);
- final int count =
ParameterFormatter.countArgumentPlaceholders3(state.copy, length,
state.indices);
- ParameterFormatter.formatMessage3(state.buffer, state.copy, length,
ARGS, count, state.indices);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency9ParamsV3(final ThreadState state) {
- state.buffer.setLength(0);
- final String STR = "p1={}, p2={}, p3={}, p4={}, p5={}, p6={}, p7={},
p8={}, p9={}";
- final int length = STR.length();
- STR.getChars(0, length, state.copy, 0);
- final int count =
ParameterFormatter.countArgumentPlaceholders3(state.copy, length,
state.indices);
- ParameterFormatter.formatMessage3(state.buffer, state.copy, length,
ARGS, count, state.indices);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency3ParamsV2(final ThreadState state) {
- state.buffer.setLength(0);
- final int count =
ParameterFormatter.countArgumentPlaceholders2("p1={}, p2={}, p3={}",
state.indices);
- ParameterFormatter.formatMessage2(state.buffer, "p1={}, p2={}, p3={}",
ARGS, count, state.indices);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency5ParamsV2(final ThreadState state) {
- state.buffer.setLength(0);
- final int count =
ParameterFormatter.countArgumentPlaceholders2("p1={}, p2={}, p3={}, p4={},
p5={}", state.indices);
- ParameterFormatter.formatMessage2(state.buffer, "p1={}, p2={}, p3={},
p4={}, p5={}", ARGS, count, state.indices);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency7ParamsV2(final ThreadState state) {
- state.buffer.setLength(0);
- final int count =
ParameterFormatter.countArgumentPlaceholders2("p1={}, p2={}, p3={}, p4={},
p5={}, p6={}, p7={}", state.indices);
- ParameterFormatter.formatMessage2(state.buffer, "p1={}, p2={}, p3={},
p4={}, p5={}, p6={}, p7={}", ARGS, count, state.indices);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency9ParamsV2(final ThreadState state) {
- state.buffer.setLength(0);
- final int count =
ParameterFormatter.countArgumentPlaceholders2("p1={}, p2={}, p3={}, p4={},
p5={}, p6={}, p7={}, p8={}, p9={}", state.indices);
- ParameterFormatter.formatMessage2(state.buffer, "p1={}, p2={}, p3={},
p4={}, p5={}, p6={}, p7={}, p8={}, p9={}", ARGS, count, state.indices);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency3Params(final ThreadState state) {
- state.buffer.setLength(0);
- final int count = ParameterFormatter.countArgumentPlaceholders("p1={},
p2={}, p3={}");
- ParameterFormatter.formatMessage(state.buffer, "p1={}, p2={}, p3={}",
ARGS, count);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency5Params(final ThreadState state) {
- state.buffer.setLength(0);
- final int count = ParameterFormatter.countArgumentPlaceholders("p1={},
p2={}, p3={}, p4={}, p5={}");
- ParameterFormatter.formatMessage(state.buffer, "p1={}, p2={}, p3={},
p4={}, p5={}", ARGS, count);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency7Params(final ThreadState state) {
- state.buffer.setLength(0);
- final int count = ParameterFormatter.countArgumentPlaceholders("p1={},
p2={}, p3={}, p4={}, p5={}, p6={}, p7={}");
- ParameterFormatter.formatMessage(state.buffer, "p1={}, p2={}, p3={},
p4={}, p5={}, p6={}, p7={}", ARGS, count);
- return state.buffer.length();
- }
-
- @Benchmark
- @BenchmarkMode(Mode.SampleTime)
- @OutputTimeUnit(TimeUnit.NANOSECONDS)
- public int latency9Params(final ThreadState state) {
- state.buffer.setLength(0);
- final int count = ParameterFormatter.countArgumentPlaceholders("p1={},
p2={}, p3={}, p4={}, p5={}, p6={}, p7={}, p8={}, p9={}");
- ParameterFormatter.formatMessage(state.buffer, "p1={}, p2={}, p3={},
p4={}, p5={}, p6={}, p7={}, p8={}, p9={}", ARGS, count);
- return state.buffer.length();
- }
+// @Benchmark
Review Comment:
Why are these benchmarks commented out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
