ppkarwasz commented on code in PR #1760:
URL: https://github.com/apache/logging-log4j2/pull/1760#discussion_r1316964203
##########
log4j-api/src/main/java/org/apache/logging/log4j/util/StackLocator.java:
##########
@@ -77,7 +77,6 @@ public final class StackLocator {
}
}
} catch (final Exception | LinkageError e) {
- System.out.println("WARNING: sun.reflect.Reflection.getCallerClass
is not supported. This will impact performance.");
Review Comment:
I would rather keep the warning, but:
- use `LowLevelLogUtil#log` instead of `System.out.println`,
- differentiate the message according to `Constants#JAVA_MAJOR_VERSION`:
- if the version is <= 8 warn about
"sun.reflect.Reflection.getCallerClass is not supported. This will impact
location-based features.",
- if the version is > 8 warn about "Runtime environment does not support
multi-release JARs. This will impact location-base features."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
