swebb2066 commented on PR #271:
URL: https://github.com/apache/logging-log4cxx/pull/271#issuecomment-1758816350
I suggest multithreadtest needs to use a layout to properly test this PR.
For example
```diff --git a/src/test/cpp/multithreadtest.cpp
b/src/test/cpp/multithreadtest.cpp
index 15ce4881..73042378 100644
--- a/src/test/cpp/multithreadtest.cpp
+++ b/src/test/cpp/multithreadtest.cpp
@@ -19,8 +19,8 @@
#include <log4cxx/logger.h>
#include <log4cxx/logmanager.h>
-#include <log4cxx/simplelayout.h>
-#include <log4cxx/appenderskeleton.h>
+#include <log4cxx/jsonlayout.h>
+#include <log4cxx/writerappender.h>
#include <thread>
#include <vector>
#include <random>
@@ -29,23 +29,12 @@
using log4cxx::Logger;
using log4cxx::LoggerPtr;
using log4cxx::LogManager;
+using log4cxx::WriterAppender;
-class NullWriterAppender : public log4cxx::AppenderSkeleton
+class NullWriterAppender : public WriterAppender
{
public:
- NullWriterAppender() {}
-
- virtual void close() {}
-
- virtual bool requiresLayout() const
- {
- return false;
- }
-
- virtual void append(const log4cxx::spi::LoggingEventPtr&
event, log4cxx::helpers::Pool& p)
- {
- // Do nothing but discard the data
- }
+ NullWriterAppender() :
WriterAppender(std::make_shared<log4cxx::JSONLayout>()) {}
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
