ppkarwasz commented on issue #1914: URL: https://github.com/apache/logging-log4j2/issues/1914#issuecomment-1784803344
@vy, The pros are mostly: - we lose an **optional** dependency. Optional dependencies are always hard to deal with correctly. Without testing I can't easily tell if [`DataSourceConnectionSource`](https://github.com/apache/logging-log4j2/blob/main/log4j-jdbc/src/main/java/org/apache/logging/log4j/jdbc/appender/DataSourceConnectionSource.java) will catch all `LinkageError`s if `log4j-jndi` is not present. I believe that the `NoClassDefFoundError` will propagate to the user. - we psychologically reassure users that tremble, when they head JNDI. Static code analysis tools might also give false positives. The cons: - we have yet another module that users need to add to their dependencies. However in `3.x` users need to add `log4j-jdbc` anyway, so they might just replace it with `log4j-jdbc-jndi`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
