rm5248 commented on PR #282:
URL: https://github.com/apache/logging-log4cxx/pull/282#issuecomment-1802757780
> One a fake source file `${CMAKE_CURRENT_BINARY_DIR}/empty-lib-stub.cpp`, I
have added to include-target, is a minimal c++ translation unit with one an
entity, named `someUnused`. It is required for some toolchains (on osx for
example), which cannot works with empty archives. This entity has an internal
linkage and does not used from any other, so, no symbol exported in result
binary. Also, please note, include-targets do not link with general targets,
so, no include-content is placed to them.
Ah, it's a separate target, I didn't see that at first. Looks good to me;
I'll merge it in tomorrow morning if there are no objections from anybody.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
