vopl opened a new pull request, #288:
URL: https://github.com/apache/logging-log4cxx/pull/288

   This fix repetitive usage of per thread cached ostringstream in 
StringOrStream-CharMessageBuffer-MessageBuffer. 
   The problem occurs when using output manipulators 
([standart](https://en.cppreference.com/w/cpp/io/manip) or custom) that change 
the state of the stream in aspect of formatting output values. Example:
   ```
   int num = 220;
   LOG4CXX_INFO(logger, "some number in hex: " << std::hex << num);
   LOG4CXX_INFO(logger, "wrongly hex number base here: " << num);
   ```
   
   I am not sure that the proposed solution is optimal, perhaps it is worth 
simply abandoning caching of the ostringstream value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to