ppkarwasz commented on code in PR #1961:
URL: https://github.com/apache/logging-log4j2/pull/1961#discussion_r1392339029
##########
log4j-api/src/main/java/org/apache/logging/log4j/util/Base64Util.java:
##########
@@ -53,7 +54,7 @@ public static String encode(final String str) {
if (str == null) {
return null;
}
- final byte [] data = str.getBytes();
+ final byte [] data = str.getBytes(Charset.defaultCharset());
Review Comment:
I marked the method as `@Deprecated` and removed its only user. The entire
`Base64Util` class can be replaced with `Base64.getEncoder()` since Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
