rm5248 commented on PR #291: URL: https://github.com/apache/logging-log4cxx/pull/291#issuecomment-1815556136
> > Would it make sense to be able to switch this at compile time for the user? > > Yes, which is done by adding `#define LOG4CXX_FORMAT_NS std` before `#include <log4cxx/logger.h>` or `LOG4CXX_FORMAT_NS=std` as a preprocessor argument It doesn't look like it checks for that though, I think you would get a warning/error about multiple defines. I would assume it actually needs to be this: ``` #define LOG4CXX_USING_STD_FORMAT @LOG4CXX_USE_STANDARD_FORMAT@ #if !defined(LOG4CXX_FORMAT_NS) && LOG4CXX_USING_STD_FORMAT #define LOG4CXX_FORMAT_NS std #elif !defined(LOG4CXX_FORMAT_NS) #define LOG4CXX_FORMAT_NS fmt #endif ``` This information should probably also be added to the `macros influencing log4cxx` page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
