rm5248 commented on code in PR #299:
URL: https://github.com/apache/logging-log4cxx/pull/299#discussion_r1400635186
##########
src/main/cpp/threadspecificdata.cpp:
##########
@@ -60,13 +60,16 @@ ThreadSpecificData& ThreadSpecificData::getDataNoThreads()
ThreadSpecificData* ThreadSpecificData::getCurrentData()
{
-#if APR_HAS_THREADS
void* pData = NULL;
+#if APR_HAS_THREADS
Review Comment:
should these `#if` be reversed, such that if it has `thread_local` that
takes precedence over APR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
