ppkarwasz commented on code in PR #2021:
URL: https://github.com/apache/logging-log4j2/pull/2021#discussion_r1410893104
##########
.github/dependabot.yaml:
##########
@@ -43,21 +43,12 @@ updates:
# Keep Logback version 1.2.x
- dependency-name: "ch.qos.logback:*"
update-types: ["version-update:semver-major",
"version-update:semver-minor"]
- # Mockito 5.x requires Java 11
- - dependency-name: "org.mockito:*"
- update-types: ["version-update:semver-major"]
- # JUnit Pioneer 2.x requires Java 11
- - dependency-name: "org.junit-pioneer:*"
- update-types: ["version-update:semver-major"]
Review Comment:
Are you sure, we can upgrade these?
These are test dependencies and tests are still compiled with `-release 8`
and **must** run on JRE 8.
##########
.github/dependabot.yaml:
##########
@@ -71,15 +62,9 @@ updates:
update-types: ["version-update:semver-minor",
"version-update:semver-patch"]
- dependency-name: "org.openrewrite.recipe:*"
update-types: ["version-update:semver-minor",
"version-update:semver-patch"]
- # Json Unit 3.x requires Java 17
- - dependency-name: "net.javacrumbs.json-unit:*"
- versions: ["[3.0.0,)"]
# LMAX Disruptor requires Java 11
- dependency-name: "com.lmax:disruptor"
versions: ["[4.0.0,)"]
- # WebCompere System Stubs requires Java 11
- - dependency-name: "uk.org.webcompere:*"
- versions: ["2.1.0,)"]
Review Comment:
Also must be `< 2.1.0`.
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/DatePatternConverterTestBase.java:
##########
@@ -119,12 +100,17 @@ private String precisePattern(final String pattern, final
int precision) {
}
@Test
- public void testFormatDateStringBuilderDefaultPattern() {
+ void testThreadLocalsConstant() {
+ assertEquals(threadLocalsEnabled, Constants.ENABLE_THREADLOCALS);
+ }
+
+ @Test
+ void testFormatDateStringBuilderDefaultPattern() {
assertDatePattern(null, date(2001, 1, 1), "2001-02-01 14:15:16,123");
}
@Test
- public void testFormatDateStringBuilderIso8601() {
+ void testFormatDateStringBuilderIso8601() {
Review Comment:
There is an OpenRewrite recipe for this: [Remove public visibility of JUnit
5
tests](https://docs.openrewrite.org/recipes/java/testing/cleanup/testsshouldnotbepublic).
I would prefer to run this recipe on all our tests in a separate PR
(although I am not strict about this).
##########
.github/dependabot.yaml:
##########
@@ -71,15 +62,9 @@ updates:
update-types: ["version-update:semver-minor",
"version-update:semver-patch"]
- dependency-name: "org.openrewrite.recipe:*"
update-types: ["version-update:semver-minor",
"version-update:semver-patch"]
- # Json Unit 3.x requires Java 17
- - dependency-name: "net.javacrumbs.json-unit:*"
- versions: ["[3.0.0,)"]
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
