rm5248 commented on code in PR #307:
URL: https://github.com/apache/logging-log4cxx/pull/307#discussion_r1418041038
##########
src/test/cpp/helpers/charsetencodertestcase.cpp:
##########
@@ -353,11 +357,10 @@ LOGUNIT_CLASS(CharsetEncoderTestCase)
private:
ThreadPackage(const ThreadPackage&);
ThreadPackage& operator=(ThreadPackage&);
- Pool p;
std::mutex lock;
std::condition_variable condition;
- volatile apr_uint32_t passCount;
- volatile apr_uint32_t failCount;
+ apr_uint32_t passCount;
Review Comment:
should we just change these to `uint32_t` and ignore APR? And/or use
`std::atomic`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
