ppkarwasz commented on PR #809: URL: https://github.com/apache/logging-log4j2/pull/809#issuecomment-1847671971
@merkisoft, The main point of @stefanvodita's PR is that `File.mkdirs` returns `false` if the directory exits or a file system error occurs, we can not differentiate the two cases. `Files.createDirectories` on the other hand throws an exception only in the latter case. I don't see anything wrong in adding a `Files.exists` call in front of `Files.createDirectories`. You can create a PR for it. **Remark**: with `Files.exists` you still need to add a "read" permission on the log dir. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
