ppkarwasz commented on code in PR #56:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/56#discussion_r1423481925
##########
pom.xml:
##########
@@ -125,7 +125,16 @@
<properties>
<!-- project version -->
- <revision>1.4.0-SNAPSHOT</revision>
+ <revision>1.4.0</revision>
Review Comment:
This shouldn't be necessary since the CI will do it.
Looking at the [`logging-parent` reusable
build](https://github.com/apache/logging-parent/blob/27335fbd2af8f377e7d100b51762144258622119/.github/workflows/deploy-release-reusable.yaml#L100),
the `git commit` instruction might fail if there is nothing to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
