vy commented on PR #82: URL: https://github.com/apache/logging-parent/pull/82#issuecomment-1858228280
> I admit that closed PRs look bad in my notifications and a repository Insights. Not sure if there are other advantages. PR complicates the existing code, we need stronger arguments than these, IMHO. > Are these `git` commands really so obscure? I commented them to specify what we want to obtain. Yes, let me give concrete examples: ``` # Must include the merge-base between head and target branch. fetch-depth: 32 ``` I have no idea what the comment tries to mean and why the magical 32. ``` # We only fetched the PR branch, we need to fetch the target branch git fetch origin "+refs/heads/$BASE:refs/remotes/origin/$BASE" ``` I don't know of a single PMC member who would understand this without reading a couple of git manpages and SO posts. If you think there are, please tell them to join us in this conversation. Can I suggest a different route: Can't you `cherry-pick` the dependabot commit (AFAIK, GitHub will recognize this and mark the PR as merged) and update the changelog in a separate commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
