vy commented on code in PR #2104: URL: https://github.com/apache/logging-log4j2/pull/2104#discussion_r1430588626
########## log4j-api/src/main/java/org/apache/logging/log4j/internal/recycler/ThreadLocalRecyclerFactoryProvider.java: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.logging.log4j.internal.recycler; + +import static java.util.Objects.requireNonNull; +import static org.apache.logging.log4j.spi.recycler.Recycler.DEFAULT_CAPACITY; + +import aQute.bnd.annotation.spi.ServiceProvider; +import edu.umd.cs.findbugs.annotations.Nullable; +import java.util.Queue; +import java.util.function.Consumer; +import java.util.function.Supplier; +import org.apache.logging.log4j.spi.LoggingSystemProperty; +import org.apache.logging.log4j.spi.recycler.AbstractRecycler; +import org.apache.logging.log4j.spi.recycler.Recycler; +import org.apache.logging.log4j.spi.recycler.RecyclerFactory; +import org.apache.logging.log4j.spi.recycler.RecyclerFactoryProvider; +import org.apache.logging.log4j.util.PropertyEnvironment; + +/** + * A {@link Recycler} factory provider such that the recycler pools objects in a fixed-size queue stored in a {@link ThreadLocal}. + * <p> + * This strategy may not be appropriate in workloads where units of work are independent of operating system threads such as reactive streams, coroutines, or virtual threads. + * For such use cases, see {@link QueueingRecyclerFactoryProvider}. + * </p> + * + * @since 3.0.0 + */ +@ServiceProvider(RecyclerFactoryProvider.class) +public final class ThreadLocalRecyclerFactoryProvider implements RecyclerFactoryProvider { + + @Override + public int getOrder() { + return 700; + } + + @Override + public String getName() { + return "threadLocal"; + } + + @Nullable + @Override + public RecyclerFactory createForEnvironment(PropertyEnvironment environment) { + requireNonNull(environment, "environment"); + final boolean threadLocalEnabled = + environment.getBooleanProperty(LoggingSystemProperty.THREAD_LOCALS_ENABLE, true); + if (!threadLocalEnabled) { + return null; + } Review Comment: Created #2105 and linked to it in #2016. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
