rm5248 commented on code in PR #316:
URL: https://github.com/apache/logging-log4cxx/pull/316#discussion_r1431499503
##########
src/main/include/log4cxx/logger.h:
##########
@@ -2056,19 +2056,21 @@ Add a new logging event containing \c message to
attached appender(s) if this lo
/**
Add a new logging event containing \c message to attached appender(s) if \c
logger is enabled for <code>DEBUG</code> events.
-@param logger the logger that has the enabled status.
-@param message a valid r-value expression of an
<code>operator<<(std::ostream&. ...)</code> overload.
-
+\usage
~~~{.cpp}
LOG4CXX_DEBUG(m_log, "AddMesh:"
<< " name " << meshName
<< " type 0x" << std:: hex << traits.Type
Review Comment:
It's not something that you modified here, but won't the `std::hex` here
also affect the later calls of `getCenter()` and `getHalfSize()`? I think the
two examples(LOG4CXX_DEBUG and LOG4CXX_DEBUG_FMT) are not equivalent in that
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
