takanuva15 commented on issue #1941:
URL:
https://github.com/apache/logging-log4j2/issues/1941#issuecomment-1868067870
Hi, a few additional questions:
1. You mentioned that I should "refactor the current `STSR#truncate`" method
into two methods, where I do truncation first and then package exclusions. In
terms of implementation, what I currently have working is:
- run package truncation on `srcWriter` into `dstWriter`
- copy the truncation output from `dstWriter` back to `srcWriter`
- run package exclusion on `srcWriter` into `dstWriter`
  Does this sound like the correct sequence of events for the
implementation?
2. For the `StackTraceStringResolverTest`, can I define test json-templates
in json files under `src/test/resources` instead of repeating the deeply-nested
`asMap(...)` calls?
3. For the `StackTraceStringResolverTest`, can we split the `@Nested` test
classes into separate files and group them all in a subpackage (eg
`layout.template.json.resolver.stacktracestring`)? The current test class is
getting close to 1000 lines with my new tests and the class is starting to look
like spaghetti code 😸
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
