chrisribble commented on issue #2144: URL: https://github.com/apache/logging-log4j2/issues/2144#issuecomment-1873404511
@ppkarwasz, I'm calling `Configurator.shutdown(loggerContext);` on the `org.apache.logging.log4j.core.LoggerContext` in a custom shutdown hook that handles graceful shutdown of my application with it receives SIGTERM. It's the very last thing that happens in our shutdown hook before the application exits (note: this is not a "web" application and we also explicitly disable log4j's built-in shutdown hooks). However, it seems like it's not really all that important to explicitly shut down log4j in this scenario, since we're just logging to the console. k8s ships our console logs for us and we aren't using async logging. In my local testing with `docker-compose stop` it seems like I always see the log line at the end of the shutdown sequence even when I remove the call to `Configurator.shutdown(loggerContext);`. So yeah, it seems like I can just remove the explicit dependency on `log4j-core`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
