jvz commented on code in PR #2148: URL: https://github.com/apache/logging-log4j2/pull/2148#discussion_r1439618118
########## src/changelog/.3.x.x/2147_add_instance_factory_dsls.xml: ########## @@ -0,0 +1,15 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="http://logging.apache.org/log4j/changelog"; + xsi:schemaLocation="http://logging.apache.org/log4j/changelog https://logging.apache.org/log4j/changelog-0.1.3.xsd"; + type="added"> + <issue id="2147" link="https://github.com/apache/logging-log4j2/issues/2147"/> + <description format="asciidoc"> + Add various DSLs for dependency injection. This includes: + + - `DI.FactoryBuilder` and related builder classes for configuring a `ConfigurableInstanceFactory`. + - Repeatable `@TestBinding` test annotation for specifying simple bindings in tests. + - `@LegacyLoggerContextSource` test annotation for specifying v1-style configuration files. + - Test extension updates to improve compatibility of different annotations. Review Comment: I could shorten the entry. ########## src/site/_release-notes/_3.x.x.adoc: ########## @@ -20,6 +20,11 @@ This release contains... +[#release-notes-3-x-x-added] +=== Added + +* Add various DSLs for dependency injection. This includes: - `DI.FactoryBuilder` and related builder classes for configuring a `ConfigurableInstanceFactory`. - Repeatable `@TestBinding` test annotation for specifying simple bindings in tests. - `@LegacyLoggerContextSource` test annotation for specifying v1-style configuration files. - Test extension updates to improve compatibility of different annotations. (https://github.com/apache/logging-log4j2/pull/2147[2147]) Review Comment: Agreed; yikes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
