vy commented on code in PR #96:
URL: https://github.com/apache/logging-parent/pull/96#discussion_r1448531180
##########
pom.xml:
##########
@@ -970,9 +970,6 @@ import org.apache.commons.codec.digest.*;
# Allow each project to override the `Multi-Release` header:
Multi-Release: $[bnd-multi-release]
Review Comment:
```suggestion
# Skipping to set `-jpms-multi-release` to `bnd-multi-release`.
# This would generate descriptors in `META-INF/versions/<version>`
directories needed for MRJs.
# Though we decided to skip it due to following reasons:
# 1. It is only needed by a handful of files in `-java9`-suffixed modules of
`logging-log4j2`.
# Hence, it is effectively insignificant.
# 2. `dependency:unpack` and `bnd:bnd-process` executions must be aligned
correctly.
# See this issue for details:
https://github.com/apache/logging-parent/issues/93
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
