rgoers commented on code in PR #2062:
URL: https://github.com/apache/logging-log4j2/pull/2062#discussion_r1449305327
##########
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java:
##########
@@ -746,6 +758,22 @@ public String getStringProperty(final String key) {
return result;
}
+ private String sourceGetProperty(ContextAwarePropertySource source,
String contextName, String key) {
+ try {
+ return source.getProperty(contextName, key);
+ } catch (Throwable ex) {
+ return null;
Review Comment:
I don't think so. The issue that was reported simply causes error messages
to be logged. The application is shutting down so an error during shutdown is
irritating. Changing that to a warning doesn't really help much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
