rm5248 commented on PR #345: URL: https://github.com/apache/logging-log4cxx/pull/345#issuecomment-1927159573
Unfortunately since this is a C++20 only fix, that build would fail with earlier versions. The optional GCC fix as well (`##__VA_ARGS__`) only works if GNU extensions are enabled. So it works if you compile with `-std=gnu++11` but fails with `-std=c++11`. There doesn't seem to be a way to test if this is enabled or not at compile time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
