ppkarwasz commented on code in PR #101:
URL: 
https://github.com/apache/logging-log4j-tools/pull/101#discussion_r1479618784


##########
log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/AsciidocData.java:
##########


Review Comment:
   I guess it is a matter of style, they are protected anyway.
   
   I thought about moving the internals of the `AsciidocConverter` to an 
`internal` package. If the methods remain `public`, this can be done without a 
single change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to