vy commented on code in PR #65:
URL:
https://github.com/apache/logging-log4j-kotlin/pull/65#discussion_r1482725233
##########
src/site/index.adoc:
##########
Review Comment:
Shouldn't we instead write the docs as as follows?
1. Encourage the usage of `withLoggingContext()` and
`withAdditionalLoggingContext()` higher level functions.
2. Briefly mention that these actually rely on `loggingContext()` and
`additionalLoggingContext()`.
##########
log4j-api-kotlin/src/test/kotlin/org.apache.logging.log4j.kotlin/ThreadContextTest.kt:
##########
Review Comment:
I am not able to find key override tests in a nested setting, that is (in
pseudocode):
```
withLoggingContext(map = (k1->k1v, k2->k2v), stack = [s1v, s2v]) {
// assert context initialization
assert(map, (k1->k1v, k2->k2v));
assert(stack, [s1v, s2v]);
// override context
withLoggingContext(map = (k3->k3v, k4->k4v), stack = [s3v, s4v]) {
// assert context initialization
assert(map, (k3->k3v, k4->k4v));
assert(stack, [s3v, s4v]);
// override context
withAdditionalLoggingContext(map = (k4->k4v*, k5->k5v), stack =
[s5v]) {
assert(map, (k3->k3v, k4->k4v*, k5->k5v));
assert(stack, [s3v, s4v, s5v]);
}
// assert context restoration
assert(map, (k3->k3v, k4->k4v));
assert(stack, [s3v, s4v]);
}
// assert context restoration
assert(map, (k1->k1v, k2->k2v));
assert(stack, [s1v, s2v]);
}
```
Unless they are already there, could you add these too, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
