vy commented on code in PR #2249:
URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1482856362
##########
log4j-api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java:
##########
@@ -56,50 +54,59 @@ public StatusConsoleListener(final Level level) {
* @throws NullPointerException on null {@code level} or {@code stream}
*/
public StatusConsoleListener(final Level level, final PrintStream stream) {
- this(level, stream, SimpleLoggerFactory.getInstance());
- }
-
- StatusConsoleListener(final Level level, final PrintStream stream, final
SimpleLoggerFactory loggerFactory) {
- this.level = Objects.requireNonNull(level, "level");
- this.stream = Objects.requireNonNull(stream, "stream");
- this.logger = Objects.requireNonNull(loggerFactory, "loggerFactory")
- .createSimpleLogger(
- "StatusConsoleListener", level,
ParameterizedNoReferenceMessageFactory.INSTANCE, stream);
+ this.level = requireNonNull(level, "level");
+ this.stream = requireNonNull(stream, "stream");
}
/**
* Sets the level to a new value.
- * @param level The new Level.
+ *
+ * @param level the new level
+ * @throws NullPointerException on null {@code level}
*/
public void setLevel(final Level level) {
- this.level = level;
+ this.level = requireNonNull(level, "level");
}
/**
- * Return the Log Level for which the Listener should receive events.
- * @return the Log Level.
+ * Sets the output stream to a new value.
+ *
+ * @param stream the new output stream
+ * @throws NullPointerException on null {@code stream}
+ * @since 2.23.0
Review Comment:
If we can, why not? Further, I don't think `2.23` is valid. That is,
`@since` is supposed to refer to a version, `2.23` is not a version, but a
version prefix. I find this pretty confusing, in particular, given Log4j had
releases of `2.1`, `2.3`, etc. versioning scheme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
