vy commented on code in PR #2278: URL: https://github.com/apache/logging-log4j2/pull/2278#discussion_r1485214280
########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/ConfigurationPropertiesOrderTest.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.logging.log4j.core.config; + +import static org.assertj.core.api.Assertions.assertThat; + +import org.apache.logging.log4j.core.Appender; +import org.apache.logging.log4j.core.appender.ConsoleAppender; +import org.junit.jupiter.api.Test; + +public class ConfigurationPropertiesOrderTest { + + @Test + void propertiesCanComeLast() { + final Configuration config = new AbstractConfiguration(null, ConfigurationSource.NULL_SOURCE) { Review Comment: Should we eat our own dog food and use `ConfigurationBuilderFactory.newConfigurationBuilder()` instead? ########## log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java: ########## @@ -670,7 +673,7 @@ protected void doConfigure() { boolean setLoggers = false; boolean setRoot = false; for (final Node child : rootNode.getChildren()) { - if (child.getName().equalsIgnoreCase("Properties")) { + if ("Properties".equalsIgnoreCase(child.getName())) { if (tempLookup == runtimeStrSubstitutor.getVariableResolver()) { LOGGER.error("Properties declaration must be the first element in the configuration"); } Review Comment: Does this block serve any purpose still? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
