ppkarwasz commented on PR #65: URL: https://github.com/apache/logging-log4j-kotlin/pull/65#issuecomment-1937852187
> @rocketraman, we (almost) always use `Squash and Commit` in Log4j. You could have done the same for this PR. That is, your PR would appear as a single commit in `main`. Doesn't that address your concern? That is really a question of commit style. Personally I prefer force pushes like @rocketraman and I almost never make merge commits. Unless the number of commits is high or commits have no well-defined purposes (e.g. a contributor changes his contribution back and forth) I don't squash either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
