erikmav commented on PR #132: URL: https://github.com/apache/logging-log4net/pull/132#issuecomment-2025622481
@FreeAndNil the ugliest adaptations I had to make with the new binary: * `Level?` on LoggingEvent and its internal data structure required adding a bunch of null checks, especially where there are comparisons of levels. Lots of these in 2 repos. It would be ideal to make that non-nullable and ensure it's set to some default like `Level.Off` or similar. * `Repository?` on Logger required adding null checks. Generally speaking this is never null in practice, but I don't see what default to set it to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
