vy commented on code in PR #2481:
URL: https://github.com/apache/logging-log4j2/pull/2481#discussion_r1570233539
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/xml/XmlConfigurationPropsTest.java:
##########
@@ -72,9 +72,17 @@ void testNoProps(final Configuration config) {
}
@Test
+ @SetTestProperty(key = StatusLogger.DEFAULT_STATUS_LISTENER_LEVEL, value =
"INFO")
@SetTestProperty(key = Constants.LOG4J_DEFAULT_STATUS_LEVEL, value =
"WARN")
Review Comment:
In order to test `DEFAULT_` has precedence over `LOG4J_`, shouldn't the
latter has a more specific level than `WARN`? That is, shouldn't `LOG4J_` level
be, say, `DEBUG`?
##########
src/site/antora/modules/ROOT/pages/manual/configuration.adoc:
##########
@@ -2219,18 +2216,6 @@ The following is a list of available global
configuration properties. Note that
until a listener is registered. In practice, a listener is registered when a
configuration is found,
and from that point onwards, status messages are only sent to the listeners
(depending on their statusLevel).
-| [[defaultStatusLevel]]log4j2.defaultStatusLevel
- ([[Log4jDefaultStatusLevel]]Log4jDefaultStatusLevel)
-| LOG4J_DEFAULT_STATUS_LEVEL
-| ERROR
-|
- The StatusLogger logs events that occur in the logging system to the console.
- During configuration, AbstractConfiguration registers a
StatusConsoleListener with the StatusLogger that may
- redirect status log events from the default console output to a file.
- The listener also supports fine-grained filtering.
- This system property specifies the default status log level for the listener
to use if the configuration does not specify a status level.
- Note: this property is used by the log4j-core implementation only after a
configuration file has been found.
-
| [[statusLoggerLevel]]log4j2.statusLoggerLevel
([[log4j2.StatusLogger.level]]log4j2.StatusLogger.level)
| LOG4J_STATUS_LOGGER_LEVEL
Review Comment:
This is incorrect, the default is `ERROR, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
