ppkarwasz commented on code in PR #2486:
URL: https://github.com/apache/logging-log4j2/pull/2486#discussion_r1572434330
##########
log4j-mongodb/src/main/java/org/apache/logging/log4j/mongodb/package-info.java:
##########
@@ -15,12 +15,13 @@
* limitations under the license.
*/
/**
- * The classes in this package contain the MongoDB provider for the NoSQL
Appender.
+ * The classes in this package contain the MongoDB provider for the NoSQL
+ * Appender.
*/
@Export
@Open("org.apache.logging.log4j.core")
-@Version("2.20.1")
-package org.apache.logging.log4j.mongodb3;
+@Version("2.21.0")
Review Comment:
Let us use `2.24.0`, i.e. the version when the class was introduced. It is
then easier to find the last Log4j version with some real changes to the module.
##########
log4j-mongodb/src/test/java/org/apache/logging/log4j/mongodb/MongoDbResolver.java:
##########
@@ -142,11 +144,11 @@ private static final class MongoClientHolder implements
CloseableResource, Suppl
private final MongoClient mongoClient;
public MongoClientHolder(final Mongod mongod, final TestProperties
props) {
- state = mongod.start(Version.Main.V3_6);
+ state = mongod.start(Version.Main.V4_4);
Review Comment:
```suggestion
state = mongod.start(Version.Main.V7_0_8);
```
Shouldn't we use the newest server version compatible with the client?
##########
pom.xml:
##########
@@ -257,8 +257,8 @@
<module>log4j-jul</module>
<module>log4j-layout-template-json</module>
<module>log4j-layout-template-json-test</module>
- <module>log4j-mongodb3</module>
<module>log4j-mongodb4</module>
+ <module>log4j-mongodb</module>
Review Comment:
_Nit_: shouldn't we use a lexicographic (alphabetic) order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
