aabmass commented on PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#issuecomment-2070792509
> A quick question just before merging it: If `trace_id` and/or `span_id` MDC values are missing, `logging.googleapis.com/trace_sampled` will still be set to `true` without `logging.googleapis.com/trace` and/or `logging.googleapis.com/spanId` fields. Will this still be okay? Would appreciate a quick LGTM from @dashpole, @punya, or @jsuereth on this point before merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
