alan0428a commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2211071869
@vy Just want to make sure we are on the same page. So for `xxxThrowablePatternConverter#format()`, the existing implementation is that when `event.getThrownProxy()` is `null`, it calls its parent `ThrowablePatternConverter#format()`. And we want to change it to create one using `ThrowableProxy::new` when it's `null` then call `ThrowableProxy#formatXxxStackTraceTo()`? As for `ThrowablePatternConverter#format()`, we want to create `ThrowableProxy` if `options` are not default, and delegate to `ThrowableProxy` for rendering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
