rm5248 commented on code in PR #389:
URL: https://github.com/apache/logging-log4cxx/pull/389#discussion_r1671389085
##########
CMakeLists.txt:
##########
@@ -170,35 +170,33 @@ IF(MSVC AND BUILD_SHARED_LIBS AND LOG4CXX_INSTALL_PDB)
)
ENDIF()
-if(UNIX)
- # Support for pkg-config in consuming projects
- set(prefix "${CMAKE_INSTALL_PREFIX}")
- set(exec_prefix "${CMAKE_INSTALL_PREFIX}")
- set(libdir "\${prefix}/${CMAKE_INSTALL_LIBDIR}")
- set(includedir "\${prefix}/${CMAKE_INSTALL_INCLUDEDIR}")
- set(VERSION
"${log4cxx_VERSION_MAJOR}.${log4cxx_VERSION_MINOR}.${log4cxx_VERSION_PATCH}")
- configure_file("${CMAKE_CURRENT_SOURCE_DIR}/liblog4cxx.pc.in"
- "${CMAKE_CURRENT_BINARY_DIR}/lib${LOG4CXX_LIB_NAME}.pc"
- )
+# Support for pkg-config in consuming projects
Review Comment:
Is `pkg-config` available on Windows? I don't think we want to always
install the .pc file.
Adding a new option to force the .pc installation feels better to me, I'm
not sure if anybody else has any thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
