vy commented on issue #2766: URL: https://github.com/apache/logging-log4j2/issues/2766#issuecomment-2253103272
> Yes it does support runtime lookups (see [Runtime evaluation of attributes](https://logging.staged.apache.org/log4j/2.x/manual/appenders.html#runtime-evaluation) I recently revamped). It just does not pass the log event as argument to `StrSubstitutor`, so some lookups don't work. Right. Can't we simply receive the `LogEvent` in `NoSqlDatabaseManager#setAdditionalFields()` and be done with it? > After auditing the lookup code, I came to the conclusion that `StrLookup` might be one of those abstractions we should consider dropping I don't think this is the right place to discuss this. > I agree that `PatternParser` is heavier than `StrSubstitutor`, but `PatternParser` parses an expression only once. `StrSubstitutor` parses a value each time it is called. Hrm... You have a point there. Given this, I am fine with both approaches, I don't have a strong preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
