ppkarwasz commented on PR #2773:
URL: https://github.com/apache/logging-log4j2/pull/2773#issuecomment-2256605972

   > In short, `useRawMessage` has value, but it is implemented incorrectly, 
IMO. Instead, I think, we should have introduced a `RegexFilterableMessage` 
contract and implement it in certain message types. Since this is rather a big 
undertaking, for the time being, I have improved `RegexFilter` in 
[33373f9](https://github.com/apache/logging-log4j2/commit/33373f90e18b5b64d51f53ac338e221de506c4de)
 to specialize on certain message types. @ppkarwasz, is this okay with you?
   
   I guess for now it is enough. We might want to add a 
`RegexFilterableMessage` (or `StringFormatMessage` or whatever the appropriate 
naming is) in the future, but we'd better discuss the new interface on 
`dev@logging` first. For the deprecation no discussion is necessary IMHO: the 
facts speak for themselves, the `getFormat()` method is not correctly defined.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to