FreeAndNil commented on code in PR #164:
URL: https://github.com/apache/logging-log4net/pull/164#discussion_r1703364772
##########
src/log4net.Tests/log4net.Tests.csproj:
##########
Review Comment:
Can you please change lines 2 to 48 to the following?
```
<PropertyGroup>
<IsTestProject>true</IsTestProject>
<TargetFrameworks>net462;net8.0</TargetFrameworks>
<NoWarn>NETSDK1138;CS1701</NoWarn>
<OutputType>Library</OutputType>
<OutputPath>bin\$(Configuration)</OutputPath>
<Configurations>Debug;Release</Configurations>
<Platforms>AnyCPU</Platforms>
<Deterministic>true</Deterministic>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<DefineConstants>TRACE;DEBUG;$(DefineConstants)</DefineConstants>
<!-- suppress analyzer mismatch warning -->
<NoWarn>CS8032</NoWarn>
</PropertyGroup>
```
The line `<IsTestProject>true</IsTestProject>` is really important, without
it only net8.0 is executed and net462 is skipped.
The other lines are just removing no longer needed garbage from the old
style project file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
