vy commented on code in PR #2783:
URL: https://github.com/apache/logging-log4j2/pull/2783#discussion_r1708646258
##########
log4j-1.2-api/src/main/java/org/apache/log4j/xml/DOMConfigurator.java:
##########
@@ -66,20 +69,34 @@
*/
public class DOMConfigurator {
+ private static boolean isFullCompatibilityEnabled() {
+ return
PropertiesUtil.getProperties().getBooleanProperty(ConfigurationFactory.LOG4J1_EXPERIMENTAL);
+ }
+
+ private static void warnFullCompatibilityDisabled() {
+ LogLog.warn(
+ "Ignoring `DOMConfigurator` call, since `log4j1.compatibility`
is not enabled.\n"
+ + "See
https://logging.staged.apache.org/log4j/2.x/migrate-from-log4j1.html#log4j1.compatibility
for details.");
+ }
Review Comment:
:bulb: Idea: Instead of these two methods, you could have only introduced a
wrapper method as follows:
```
private static void whenFullCompatibilityEnabled(ThrowingRunnable runnable) {
// ...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
